Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch box for long press is not aligned to the message when a reaction is present #2021

Closed
TaharS opened this issue Mar 20, 2023 · 4 comments · Fixed by #2196
Closed

Touch box for long press is not aligned to the message when a reaction is present #2021

TaharS opened this issue Mar 20, 2023 · 4 comments · Fixed by #2196
Labels
Bug Something isn't working in the SDK released User Experience

Comments

@TaharS
Copy link

TaharS commented Mar 20, 2023

Describe the bug
On an Android device, when a user has reacted to a message (any emote), the next time it wants to long press on the message, the hit box is actually push to the bottom which stops an accurate selection of the message.
Screen Shot 2023-03-20 at 2 15 42 PM
On this screenshot, you can see that the hit box is actually lower by the size of the reaction. Which doesn't register long press is the user doesn't precisely hold press on the second half of the message.
It is particularly annoying for 1 liner messages (less for 2+ lines)

Dev environment info (please complete/provide the following information):

  • Package version
    "stream-chat": "8.2.1",
    "stream-chat-react-native": "^5.11.2",
  • react-native or expo version
    "react-native": "0.70.3",
  • Device/Emulator (android/ios) and OS version
    Android Emulator Pixel 5 API 33

To Reproduce
Steps to reproduce the behavior:

  1. Open the app on Android
  2. Select a channel
  3. Send a one liner message
  4. Long press and add a reaction
  5. Try to long press again while touching the top of the message (failure to open overlay)
  6. Try to long press again while touching the lower part of the message (successfully open the overlay)

Expected behavior
Overlay should display properly on long press

Additional context
n/a

Screenshots
n/a

@vanGalilea
Copy link
Contributor

Might be related to #1982

@vanGalilea vanGalilea added the Bug Something isn't working in the SDK label Mar 21, 2023
@khushal87
Copy link
Member

Hey @TaharS, thanks for pointing out the bug to us. We were able to reproduce this issue on our side and we will try to come up with a fix.

@TaharS
Copy link
Author

TaharS commented Mar 28, 2023

It is reproducible on iOS as well btw :)

@vanGalilea vanGalilea changed the title Android touch box for long press is not aligned to the message when a reaction is present Touch box for long press is not aligned to the message when a reaction is present Apr 6, 2023
@stream-ci-bot
Copy link
Contributor

🎉 This issue has been resolved in version 5.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working in the SDK released User Experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants