Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting and tapping on user mentions #5408

Merged
merged 22 commits into from
Oct 21, 2024

Conversation

VIPlearner
Copy link

@VIPlearner VIPlearner commented Sep 15, 2024

🎯 Goal

The goal of this PR is to add functionality that allows users to click/tap user mentions.
Issue link: #5263

🛠 Implementation details

I basically scan the string for any user mentions using the @ symbol as a reference and checking the mentionedUser list to confirm the user and register the part of the string as clickable

🎨 UI Changes

Before After

Screenshot 2024-09-15 at 08 53 48

Screenshot 2024-09-15 at 08 51 41

🧪 Testing

Tag a user when sending a message and send. The tagged username will be clickable However nothing will happen when clicked you could however check the logs to confirm that the tagged username is being clicked

@VIPlearner VIPlearner requested a review from a team as a code owner September 15, 2024 07:57
@VIPlearner VIPlearner changed the title Develop Highlighting and tapping on user mentions Sep 15, 2024
@aleksandar-apostolov
Copy link
Collaborator

Hello @VIPlearner,

Thank you for your valuable contribution. We truly appreciate your efforts and will carefully consider your suggestion. Before moving forward, we'll need to consult with our product team to determine if we can include this in our SDK, as we aim to maintain parity with other platforms.

Best regards

@aleksandar-apostolov
Copy link
Collaborator

Hey @VIPlearner

Before proceeding further, please follow these steps to ensure code quality / styling and stability:

Fix styling issues and update the API File:

Run the following commands to fix any styling issues and update the API file:

./gradlew apiDump spotlessApply

Resolve klint Check Failures:

The klint check is currently failing. You can identify and fix the issues locally by running:

./gradlew detekt

Ensure unit tests stability:

Verify that no existing unit tests are broken by running the tests. Address any failures before proceeding.

@VIPlearner
Copy link
Author

Hi @aleksandar-apostolov Please I've updated the branch
Thanks

IsaacNewton111 and others added 3 commits September 20, 2024 08:30
…elop

# Conflicts:
#	stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/MessagesActivity.kt
#	stream-chat-android-compose/api/stream-chat-android-compose.api
@aleksandar-apostolov aleksandar-apostolov removed the request for review from skydoves September 27, 2024 08:26
@aleksandar-apostolov
Copy link
Collaborator

aleksandar-apostolov commented Sep 27, 2024

Hi @VIPlearner & @IsaacNewton111
Did you sign the Stream CLA?
As external contributors you need to do so before we can merge the PR.

Thanks

@aleksandar-apostolov aleksandar-apostolov linked an issue Sep 27, 2024 that may be closed by this pull request
@VIPlearner
Copy link
Author

Hi @aleksandar-apostolov yes please
I have signed the CLA that was one of the first things i did while going through the checklist thanks

@VIPlearner
Copy link
Author

However @aleksandar-apostolov Please I have a question
I appreciate your help with the PR. I noticed that there’s some alignment you were considering with the product team, and I’d love to better understand the project’s direction so I can make more meaningful contributions in the future. Could you share any guidance on some of the immediate goals or priorities for the project?
I’ve enjoyed working with this project and would like to contribute more if possible.
Thanks

@VIPlearner VIPlearner requested a review from kanat October 1, 2024 19:03
@aleksandar-apostolov
Copy link
Collaborator

However @aleksandar-apostolov Please I have a question I appreciate your help with the PR. I noticed that there’s some alignment you were considering with the product team, and I’d love to better understand the project’s direction so I can make more meaningful contributions in the future. Could you share any guidance on some of the immediate goals or priorities for the project? I’ve enjoyed working with this project and would like to contribute more if possible. Thanks

Hey @VIPlearner

Thanks for your question and for your efforts on the PR! I appreciate your interest in aligning with our goals. While there are ongoing discussions with the product team about new features, our continuous focus remains on ensuring a solid and stable foundation for the project. Any contributions towards refining the core features and improving stability are always valuable. Looking forward to seeing more of your work!

Copy link
Member

@JcMinarro JcMinarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Fix the conflicts and we can merge it

@VIPlearner
Copy link
Author

Done @JcMinarro

@JcMinarro JcMinarro enabled auto-merge (squash) October 17, 2024 23:02
auto-merge was automatically disabled October 18, 2024 23:07

Head branch was pushed to by a user without write access

@JcMinarro JcMinarro merged commit 5d9420b into GetStream:develop Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlighting and tapping on user mentions
5 participants