[PBE-5969] UnreadLabel shouldn't appear when only deleted messages are unread #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
changed the title
JcMinarro
force-pushed
the
fix/unread-label-over-deleted-message
branch
from
00d8c11
to
43f4747
Compare
aleksandar-apostolov
approved these changes
Sep 10, 2024
aleksandar-apostolov
deleted the
fix/unread-label-over-deleted-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently, when a message is deleted, the read are updated removing them from the deleted message and adding them to the previous message. It causes that a deleted message on the last possition is always marked as unread.
Only non-deleted messages should be elegible to be marked as unread
🛠 Implementation details
UnreadLabel is not added on the case that only deleted messages are after the last read message
🎨 UI Changes
Screen_recording_20240910_125044.webm
Screen_recording_20240910_124628.webm
🎉 GIF