-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBE-3762] Polls API #5273
Merged
Merged
[PBE-3762] Polls API #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
force-pushed
the
feature/polls-api
branch
from
June 4, 2024 11:16
c65bff9
to
c4c81a2
Compare
JcMinarro
force-pushed
the
feature/polls-api
branch
from
June 10, 2024 09:32
c4c81a2
to
4a667aa
Compare
skydoves
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! I left a trivial comment for Compose.
stream-chat-android-core/src/main/java/io/getstream/chat/android/models/Poll.kt
Show resolved
Hide resolved
kanat
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still miss some endpoints and params for Polls, but overall it looks good 👍
skydoves
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Implement the Low-Level API to create and interact with Polls.
The
Poll
is a new class withinMessage
and contains all info about the poll.There are new Events related with polls, providing poll info and the updated message as well.
🎉 GIF