Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-3762] Polls API #5273

Merged
merged 16 commits into from
Jun 13, 2024
Merged

[PBE-3762] Polls API #5273

merged 16 commits into from
Jun 13, 2024

Conversation

JcMinarro
Copy link
Member

@JcMinarro JcMinarro commented Jun 3, 2024

🎯 Goal

Implement the Low-Level API to create and interact with Polls.
The Poll is a new class within Message and contains all info about the poll.
There are new Events related with polls, providing poll info and the updated message as well.

🎉 GIF

@JcMinarro JcMinarro changed the title Feature/polls api [PBE-3762] Polls api Jun 4, 2024
@JcMinarro JcMinarro changed the title [PBE-3762] Polls api [PBE-3762] Polls API Jun 4, 2024
@JcMinarro JcMinarro marked this pull request as ready for review June 5, 2024 06:55
@JcMinarro JcMinarro requested a review from a team as a code owner June 5, 2024 06:55
@JcMinarro JcMinarro requested a review from kanat June 5, 2024 06:56
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! I left a trivial comment for Compose.

Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still miss some endpoints and params for Polls, but overall it looks good 👍

@skydoves skydoves self-requested a review June 12, 2024 23:55
@JcMinarro JcMinarro merged commit 5d0f505 into develop Jun 13, 2024
7 checks passed
@JcMinarro JcMinarro deleted the feature/polls-api branch June 13, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants