Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i74] fix multiline support in XML message composer #4898

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jul 26, 2023

🎯 Goal

Fix multiline support in XML message Composer.
No ticket for this.
It's a side-effect of #4828

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat added the v6-beta An issue for targeting v6-beta label Jul 26, 2023
@kanat kanat marked this pull request as ready for review July 26, 2023 18:38
@kanat kanat requested a review from a team as a code owner July 26, 2023 18:38
@kanat kanat changed the title fix multiline support in XML message composer [4828] fix multiline support in XML message composer Jul 26, 2023
@kanat kanat changed the title [4828] fix multiline support in XML message composer [i74] fix multiline support in XML message composer Jul 26, 2023
@kanat kanat merged commit 003c83a into develop Jul 26, 2023
7 checks passed
@kanat kanat deleted the issue/multiline-support branch July 26, 2023 19:44
@kanat kanat requested a review from JcMinarro July 26, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v6-beta An issue for targeting v6-beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant