Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/channel typing indicator #4867

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Conversation

JcMinarro
Copy link
Member

@JcMinarro JcMinarro commented Jul 10, 2023

🎯 Goal

Add typing indicator on the channel list view.
Fix: #4747

🛠 Implementation details

Added typing users to ChannelItem entity and adding a new bind() method that take as argument the ChannelItem instance instead of the Channel

🎉 GIF

@JcMinarro JcMinarro requested a review from a team as a code owner July 10, 2023 14:27
@JcMinarro JcMinarro requested a review from kanat July 10, 2023 14:28
Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JcMinarro JcMinarro enabled auto-merge (rebase) July 10, 2023 18:44
@JcMinarro JcMinarro force-pushed the feature/channel-typing-indicator branch from 3c9e6bd to af6ca7e Compare July 10, 2023 18:45
@JcMinarro JcMinarro added the v5 label Jul 10, 2023
@JcMinarro JcMinarro merged commit 4055d0a into v5 Jul 10, 2023
5 checks passed
@JcMinarro JcMinarro deleted the feature/channel-typing-indicator branch July 10, 2023 18:54
@JcMinarro JcMinarro linked an issue Jul 10, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support showing "user x is typing" is channel list
2 participants