Fixed some logic around enabling mvcp

GetStream · Apr 8, 2021 · 3541fb1 · 3541fb1
1 parent de70564
commit 3541fb1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 17 deletions.
diff --git a/android/src/main/java/com/mvcpscrollviewmanager/MvcpScrollViewManagerModule.java b/android/src/main/java/com/mvcpscrollviewmanager/MvcpScrollViewManagerModule.java
@@ -58,19 +58,24 @@ public void run() {
           final UIManagerModuleListener uiManagerModuleListener = new UIManagerModuleListener() {
             @Override
             public void willDispatchViewUpdates(final UIManagerModule uiManagerModule) {
-              ReactViewGroup mContentView = (ReactViewGroup)scrollView.getChildAt(0);
-              if (mContentView == null) return;
-
-              ScrollViewUIHolders.currentScrollY = scrollView.getScrollY();
-
-              for (int ii = minIndexForVisible; ii < mContentView.getChildCount(); ++ii) {
-                View subview = mContentView.getChildAt(ii);
-                if (subview.getTop() >= ScrollViewUIHolders.currentScrollY) {
-                  ScrollViewUIHolders.prevFirstVisibleTop = subview.getTop();
-                  ScrollViewUIHolders.firstVisibleView = subview;
-                  break;
+              uiManagerModule.prependUIBlock(new UIBlock() {
+                @Override
+                public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
+                  ReactViewGroup mContentView = (ReactViewGroup)scrollView.getChildAt(0);
+                  if (mContentView == null) return;
+
+                  ScrollViewUIHolders.currentScrollY = scrollView.getScrollY();
+
+                  for (int ii = minIndexForVisible; ii < mContentView.getChildCount(); ++ii) {
+                    View subview = mContentView.getChildAt(ii);
+                    if (subview.getTop() >= ScrollViewUIHolders.currentScrollY) {
+                      ScrollViewUIHolders.prevFirstVisibleTop = subview.getTop();
+                      ScrollViewUIHolders.firstVisibleView = subview;
+                      break;
+                    }
+                  }
                 }
-              }
+              });
             }
           };
 

diff --git a/src/FlatList.android.tsx b/src/FlatList.android.tsx
@@ -23,11 +23,9 @@ export default (React.forwardRef(
     const propAutoscrollToTopThreshold =
       mvcp?.autoscrollToTopThreshold || -Number.MAX_SAFE_INTEGER;
     const propMinIndexForVisible = mvcp?.minIndexForVisible || 1;
-
     const hasMvcpChanged =
       autoscrollToTopThreshold.current !== propAutoscrollToTopThreshold ||
       minIndexForVisible.current !== propMinIndexForVisible;
-
     const enableMvcp = () => {
       if (!flRef.current) return;
 
@@ -45,9 +43,6 @@ export default (React.forwardRef(
     };
 
     const enableMvcpWithRetries = () => {
-      autoscrollToTopThreshold.current = propAutoscrollToTopThreshold;
-      minIndexForVisible.current = propMinIndexForVisible;
-
       return enableMvcp()?.catch(() => {
         /**
          * enableMaintainVisibleContentPosition from native module may throw IllegalViewOperationException,
@@ -86,6 +81,8 @@ export default (React.forwardRef(
       if (isMvcpEnabled.current && !hasMvcpChanged) {
         return;
       }
+      autoscrollToTopThreshold.current = propAutoscrollToTopThreshold;
+      minIndexForVisible.current = propMinIndexForVisible;
 
       isMvcpEnabled.current = true;
       disableMvcp().then(enableMvcpWithRetries);