Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved cache tag invalidation from ImportQueueWorker to ImportService #4345

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

kaise-lafrai
Copy link
Contributor

@kaise-lafrai kaise-lafrai commented Nov 20, 2024

Fixes https://jira.cms.gov/browse/WCMS-19169

Describe your changes

QA Steps

CRON

  • Create a new dataset with a csv file containing the following data Bike_Lane.csv
  • Confirm the dataset is ready to be imported here /admin/dkan/datastore/status
  • Run ddev drush cron to trigger import
  • Confirm the import worked by navigating to the endpoints like this: example: https://dkan-project.ddev.site/api/1/datastore/query/[_dataset uuid_]/[distribution index]
  • Be sure to select 'Last Updated' as a trigger here /admin/dkan/datastore
  • Make a change to the original uploaded file "Bike_Lane" and the last updated date time on the dataset.
  • Run cron twice
  • Confirm the re-import and cache tag invalidation worked by navigating to the endpoints like this: example: https://dkan-project.ddev.site/api/1/datastore/query/[_dataset uuid_]/[distribution index] and confirm that the data changed.

DRUSH

  • Perform the same steps as above but instead of using the cron to import tasks, instead use the provided rush commands to drop and import the dataset.
  • Update the datafile again and run ddev drush dkan:datastore:drop and ddev drush dkan:datastore:import
  • Confirm the re-import and cache tag invalidation worked by navigating to the endpoints like this: example: https://dkan-project.ddev.site/api/1/datastore/query/[_dataset uuid_]/[distribution index] and confirm that the data changed.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

…ervices to factory classes, adjust kernel tests
@kaise-lafrai kaise-lafrai self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant