Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on weitzman/drupal-test-traits #4256

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Remove dependency on weitzman/drupal-test-traits #4256

merged 7 commits into from
Aug 21, 2024

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Aug 7, 2024 •
edited
Loading

  • Removes weitzman/drupal-test-traits from dependencies.
  • Constraints PHPUnit to ^9.6 which fits our current requirements.
  • Deprecates Drupal\Tests\common\Traits\CleanUp which should not be necessary in DKAN core.
  • Requires a change to getdkan/ddev-dkan to allow for different test autoloaders. Merged and released: https://github.com/GetDKAN/ddev-dkan/releases/tag/1.2.0 ✅
  • Follow-up with a change to getdkan/recommended-project which will remove DTT from its dev dependencies.

@paul-m paul-m changed the title Remove dependency on drupal-test-traits Remove dependency on weitzman/drupal-test-traits Aug 7, 2024
@paul-m paul-m mentioned this pull request Aug 8, 2024
Merged
@paul-m
Copy link
Contributor Author

paul-m commented Aug 8, 2024

Added a branch to make sure we can still use dtt with the dkan ddev addon: https://github.com/GetDKAN/dkan/tree/21895-remove-dtt-test-only

@paul-m paul-m marked this pull request as ready for review August 21, 2024 17:35
dmundra
dmundra approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and nice to see a dependency being removed.

@dafeder dafeder merged commit af1f25e into 2.x Aug 21, 2024
10 checks passed
@dafeder dafeder deleted the 21895-remove-dtt branch August 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmundra dmundra dmundra approved these changes

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-m @dafeder @dmundra