Use EntityTypeManagerInterface declaration instead of EntityTypeManager (Nitpick)

[stefan-korn]

Current Behavior

It seems more approriate to use EntityTypeManagerInterface as declaration type for the entityTypeManager property in Drupal\metastore\Nodewrapper\Data.

Otherwise for example the call to new Data in _metastore_search_is_dataset is complaining about the declaration type.

This surely is a nitpick, but since IDE is constantly reminding me on this ...

Expected Behavior

no complaining about declaration type anymore

Steps To Reproduce

let your IDE check the call to new Data in _metastore_search_is_dataset

Relevant log output (optional)

No response

Anything else?

No response

[paul-m]

Thanks.

I think your nitpick is 100% correct, and we should change that. We should also be nitpicky and fix NodeDataFactory in a similar way. (Inject interfaces instead of concrete classes.) Go ahead and add that to the PR if you'd like.

[stefan-korn]

Okay, added NodeDataFactory and some other places too.