Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #41

Merged
merged 16 commits into from
Dec 12, 2023
Merged

Fix failing tests #41

merged 16 commits into from
Dec 12, 2023

Conversation

paul-m
Copy link
Collaborator

@paul-m paul-m commented Dec 7, 2023 •
edited
Loading

  • Removes webimage_extra_packages from config.dkan.yaml. This was unused anyway and was leading to build errors.
  • Changes tests' project names to be unique, so their directories are not re-used.
  • Changes dkan-init.bats to install from DKAN's recommended project 10.0.0, since 10.1.0 is now our default. The point of the test was to build from a non-standard version.

@paul-m paul-m marked this pull request as draft December 8, 2023 14:50
@paul-m paul-m marked this pull request as ready for review December 12, 2023 02:22
jastraat
jastraat approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jastraat jastraat merged commit dc7f819 into main Dec 12, 2023
2 checks passed
@jastraat jastraat deleted the fix-tests branch December 12, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jastraat jastraat jastraat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-m @jastraat