Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCMS-21593: Move rows per page control above data table and adjust other UI elements #231

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

brdunfield
Copy link
Contributor

No description provided.

@@ -24,7 +24,7 @@ const DataTablePageResults = ({
const page = offset / limit;
const startTotal = () => (page * limit + 1)
return (
<p className={`ds-u-margin-bottom--2 ${className}`}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved to the ResourceHeader component to preserve this style on the /data route

Copy link
Member

@dgading dgading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great! 🥇

@brdunfield brdunfield merged commit 72cf4cd into main Jul 22, 2024
1 check passed
@brdunfield brdunfield deleted the WCMS-21593 branch July 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants