Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCMS-20331: Add ErrorBoundary component #221

Merged
merged 1 commit into from
Jun 24, 2024
Merged

WCMS-20331: Add ErrorBoundary component #221

merged 1 commit into from
Jun 24, 2024

Conversation

brdunfield
Copy link
Contributor

No description provided.

@brdunfield brdunfield marked this pull request as ready for review June 20, 2024 18:42
dgading
dgading approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@dgading dgading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix worked for the cache busters and the error boundry looked good. I just removed the fix from the compiled main.js and tested with a cache buster.

@brdunfield brdunfield merged commit 9a868b1 into main Jun 24, 2024
1 check passed
@brdunfield brdunfield deleted the WCMS-20331 branch June 24, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgading dgading dgading approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brdunfield @dgading