New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for schema and set default to {} in useDatastore #200

Merged

dgading merged 2 commits into main from fix-missing-schema-error

Apr 22, 2024

Member

dgading commented Apr 22, 2024

If a dataset was visited before the cron tasks had built it there were two places looking at schema[id] could fail:

Line 58, needed to check for schema before checking for the id key
the original default for schema in useDatastore was an empty object, but on line 65 it would be set to null or undefined which would then break every component that was looking for keys in the resource.schema object.


          Check for schema and set default to {} in useDatastore

6223ab3

dcgoodwin2112 approved these changes

View reviewed changes

Contributor

dcgoodwin2112 left a comment

lgtm 👍


          Bump to 3.1.7

ab9a63e

dgading merged commit cc38ef3 into main

1 check passed

dgading deleted the fix-missing-schema-error branch

April 22, 2024 19:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet