[#81] Add prettier #311
Merged
[#81] Add prettier #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need the .prettierrc at all? AFAIK the two settings are the default settings, now? I do not mind the extra file, but I think it's prettier (pun intended ;-)) to explicitly set only those settings that differ from defaults, just to make it easier to understand what was changed. |
|
Can you add [#311] in front of each commit message so that your commits are linked to the issue? |
cafischer
requested changes
Oct 29, 2023
alex-simm
added a commit
that referenced
this pull request
Oct 29, 2023
alex-simm
added a commit
that referenced
this pull request
Oct 29, 2023
alex-simm
added a commit
that referenced
this pull request
Oct 29, 2023
alex-simm
added a commit
that referenced
this pull request
Oct 29, 2023
alex-simm
added a commit
that referenced
this pull request
Oct 29, 2023
alex-simm
force-pushed
the
81-prettier
branch
from
4be5794 to
a0d9f87
Compare
alex-simm
added a commit
that referenced
this pull request
Oct 29, 2023
Sure, I have update them |
alex-simm
added a commit
that referenced
this pull request
Oct 29, 2023
|
Maybe you can also squash some commits. |
alex-simm
force-pushed
the
81-prettier
branch
from
50a4edc to
2862ad7
Compare
|
Looks good now! :) |
cafischer
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds prettier with a pre-commit hook. It formats css, scss, and javascript files. I left the formatting options mostly to their default values.