Merge pull request #1 from toufik-airane/master

Fix OS Command Injection on Jison
GerHobbelt · Jun 16, 2020 · 979a6ef · 979a6ef
2 parents bcf986e + 6ea9dcc
commit 979a6ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ports/csharp/Jison/Jison/csharp.js b/ports/csharp/Jison/Jison/csharp.js
@@ -1,6 +1,6 @@
 var fs = require('fs'),
     util = require('util'),
-    exec = require('child_process').exec,
+    execFile = require('child_process').execFile,
     path = require('path');
 
 GLOBAL.convertToSyntax = function (types, body) {
@@ -16,7 +16,7 @@ function puts(error, stdout, stderr) {
 
 console.log("Executing: " + "jison " + process.argv[2]);
 
-exec("jison " + process.argv[2], function (error) {
+execFile("jison", [process.argv[2]], function (error) {
     if (error) {
         console.log(error);
         return;

diff --git a/ports/php/php.js b/ports/php/php.js
@@ -1,6 +1,6 @@
 var fs = require('fs'),
     util = require('util'),
-    exec = require('child_process').exec,
+    execFile = require('child_process').execFile,
     path = require('path');
 
 GLOBAL.convertToSyntax = function (types, body) {
@@ -16,7 +16,7 @@ function puts(error, stdout, stderr) {
 
 console.log("Executing: " + "jison " + process.argv[2]);
 
-exec("jison " + process.argv[2], function (error) {
+execFile("jison", [process.argv[2]], function (error) {
     if (error) {
         console.log(error);
         return;