Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/add dynamic ratings trek #678

Conversation

JordaneNS
Copy link
Collaborator

Détails de la PR

Ajout des cotations dynamiques (ratings,ratings_description) sur les fiches rando

Screenshots

image

frontend/src/modules/details/api.ts Outdated Show resolved Hide resolved
frontend/src/modules/details/api.ts Show resolved Hide resolved
@dtrucs
Copy link
Collaborator

dtrucs commented Jun 3, 2022

This PR looks good to me 👍
Ok to merge after fixing the CI alerts

@JordaneNS
Copy link
Collaborator Author

JordaneNS commented Jun 8, 2022

@dtrucs Hello :)
I fixed the errors of ts but I still have 1 test that doesn't pass, I don't understand why.

@dtrucs
Copy link
Collaborator

dtrucs commented Jun 9, 2022

@dtrucs Hello :) I fixed the errors of ts but I still have 1 test that doesn't pass, I don't understand why.

You need to create mock files for the trekRating module. Look at the beginning of the Details.test.tsx file to see how the other modules are mocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants