Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all ODC Slack links to the new ODC Discord link #1258

Merged
merged 13 commits into from
Aug 6, 2024

Conversation

benji-glitsos-ga
Copy link
Collaborator

Proposed changes

The ODC Slack is being deprecated in favour of the ODC Discord, so we are updating all our links across all platforms.

Closes issues (optional)

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@benji-glitsos-ga benji-glitsos-ga marked this pull request as draft August 6, 2024 01:10
@benji-glitsos-ga benji-glitsos-ga marked this pull request as ready for review August 6, 2024 01:46
@benji-glitsos-ga
Copy link
Collaborator Author

@robbibt Ready for review

@robbibt
Copy link
Member

robbibt commented Aug 6, 2024

Thanks @benji-glitsos-ga! looks great, I added a discord badge to the readme too. Will let tests pass then accept/merge

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic, thanks @benji-glitsos-ga

@robbibt robbibt merged commit 566a25d into develop Aug 6, 2024
1 check passed
@robbibt robbibt deleted the feature/odc-discord-links-update branch August 6, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants