Remove R interface #293
Merged
Remove R interface #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfisikop
force-pushed
the
remove_R_interface
branch
from
e2662a9 to
8f7a9f2
Compare
vfisikop
force-pushed
the
remove_R_interface
branch
from
6366dbf to
a8d9d6a
Compare
vfisikop
force-pushed
the
remove_R_interface
branch
from
a8d9d6a to
4c6bcc3
Compare
TolisChal
reviewed
Mar 7, 2024
test/crhmc_sampling_test.cpp
Outdated
| @@ -13,7 +13,7 @@ | |||
| #include "doctest.h" | |||
| #include "generators/known_polytope_generators.h" | |||
| #include "misc/misc.h" | |||
| #include "ode_solvers.hpp" | |||
| #include "ode_solvers/ode_solvers.hpp" | |||
TolisChal
reviewed
Mar 7, 2024
| #include "random.hpp" | ||
| #include "random/uniform_int.hpp" | ||
| #include "random/normal_distribution.hpp" | ||
| #include "random/uniform_real_distribution.hpp" | ||
|
|
||
| #include "cartesian_geom/cartesian_kernel.h" | ||
| #include "diagnostics/univariate_psrf.hpp" |
There was a problem hiding this comment.
Do we use psrf in this test (since the samples are matrices)
There was a problem hiding this comment.
it is used to compute the score few lines below
TolisChal
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove R interface and update CI to test Rvolesti repository with current develop.
From now on the development of the R interface will happen in https://github.com/GeomScale/Rvolesti. However, to test if the changes in volesti C++ code break the R interface we add some CI tests.