Order polytope related fixes and improvements #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaithak
changed the title
vaithak
changed the title
TolisChal
reviewed
Sep 19, 2021
| std::pair<Point, NT> _innerball; | ||
|
|
||
| #ifndef VOLESTIPY // as _A is never normalized in closed form | ||
| _innerball = ComputeChebychevBall<NT, Point>(A, b); // use lpsolve library | ||
| #ifndef VOLESTIPY |
There was a problem hiding this comment.
VOLESTIPY is always undefined. Plz use only ComputeChebychevBall<NT, Point>(A, b)
There was a problem hiding this comment.
@TolisChal is VOLESTIPY needed in the library now?
There was a problem hiding this comment.
now the function returns just ComputeChebychevBall<NT, Point>(A, b)
TolisChal
reviewed
Sep 19, 2021
vissarion
approved these changes
Sep 20, 2021
TolisChal
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in the PR have been pulled apart from #171 for easy reviewal and better readability.