Skip to content

Commit

Permalink
Update comment regarding computing of the minimum positive eigenvalue…
Browse files Browse the repository at this point in the history
… of the GEP
  • Loading branch information
atrayees authored Jun 12, 2024
1 parent 91b10d4 commit f872b12
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/matrix_operations/EigenvaluesProblems.h
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class EigenvaluesProblems<NT, Eigen::Matrix<NT,Eigen::Dynamic,Eigen::Dynamic>, E
Spectra::DenseSymMatProd<NT> op(B);
Spectra::DenseCholesky<NT> Bop(-A);

// Construct generalized eigen solver object, requesting the largest three generalized eigenvalues
// Construct generalized eigen solver object, computing the minimum positive eigenvalue by computing the largest eigenvalue of the inverse Generalized Eigenvalue Problem
// An empirical value of ncv that gives a better performance
// TODO: tune this implementation by tuning the parameters like ncv
int ncv = std::min(std::max(10, matrixDim/20), matrixDim);
Expand Down

0 comments on commit f872b12

Please sign in to comment.