Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md file #21

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Update README.md file #21

merged 3 commits into from
Mar 29, 2024

Conversation

FareheSoheil
Copy link
Contributor

Fixed

devtools::tests()

to

devtools::test()

and added a small guide for running the tests.

vfisikop
vfisikop reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@vfisikop vfisikop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

README.md Outdated
devtools::run_examples()
```

For running the tests, user must be in the /tests directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. I have created a new pull request.

@FareheSoheil
Copy link
Contributor Author

Extra explanation removed.

@vissarion
Copy link
Member

Thanks! Please do not create more than one PR for the same topic!

@vissarion vissarion merged commit 5c6e645 into GeomScale:develop Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfisikop vfisikop vfisikop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FareheSoheil @vissarion @vfisikop