Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make R work with R classes and changes from volesti develop #15

Merged
merged 17 commits into from
Feb 29, 2024

Conversation

vfisikop
Copy link
Contributor

@vfisikop vfisikop commented Feb 26, 2024

This is a major PR that consist of mainly the following changes:

  • combine functionality from develop of volesti (new functions) with structure (R classes instead of modules) from current CRAN package.
  • remove submodules and add needed code as part of the package (I found it more convenient especially in the case of CRAN where there are a lot of limitations in the package structure) NOTE: some commits in this PR experiment with submodules and git sparse-checkout and I kept them for future reference (see e.g. github actions)
  • lpsolve structure is changed, now it uses the same structure as lpSolve cran package, which is easier to maintain and update. Update can be performed by following the following steps:
    • download new lpsolve source code inside src
    • copy and update Makefile in lpSolve/src
    • check and update (if needed) the lpSolve_patches
    • update the copyright notes (version number)

@vfisikop vfisikop force-pushed the fix/cran branch 2 times, most recently from 1447819 to 174504e Compare February 27, 2024 09:03
@vfisikop vfisikop changed the title Make R work with R classes and changes from develop Make R work with R classes and changes from volesti develop Feb 27, 2024
@vfisikop vfisikop force-pushed the fix/cran branch 4 times, most recently from 7889e08 to 0ef9a34 Compare February 28, 2024 12:51
@vfisikop vfisikop merged commit 001005f into GeomScale:main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant