-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash if the minimum and maximum depth are the same. #704
Fix crash if the minimum and maximum depth are the same. #704
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. However coveralls is failing, and the doc tester is failing with this warning:
/home/docs/checkouts/readthedocs.org/user_builds/gwb/checkouts/704/doc/sphinx/user_manual/cookbooks/index.md:8: WARNING: 'toctree': Invalid options format: expected key to start at column 0 [myst.directive_option]
the coveralls stated a rate limiting, so I am just rerunning it and that seems to work for now. I will have to take a closer look at the warning though at some point. I am not sure why the doctester is failing though. I tried to fix it, but I didn't manage yet... |
I will let you judge which of these testers should be fixed before merging. I think the code change itself is correct. |
Since the readthedocs problem is unrelated to this pull request (I probably should have split the other fixes into separate pull requests to start with) and I agree that the code chagnes are correct, I will merge this and make a separate issue for the readthedocs compilation problem. Thanks for the review @gassmoeller! |
use the top temperature in that case.