Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constant_angle_in_spherical_domain_issue.md #629

Merged
merged 2 commits into from
Feb 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
Constant angle in spherical domain issue
========================================

There is one last concept we need to discuss before we can move on to the {ref}`part:user_manual:chap:basic_starter_tutorial:sec:index`, which is the problem of defining what a constant angle in a sphere is. This does not matter for Cartesian models, but is important fore line features in spherical models.
There is one last concept we need to discuss before we can move on to {ref}`part:user_manual:chap:basic_starter_tutorial:sec:index`, this is the problem of defining a constant angle in a sphere. This does not matter for Cartesian models but is important for line features in spherical models.

The issue arises when you want to define a line with a certain angle to the surface in a sphere. The problem here is that there are two ways of looking at this. The first way is to see a constant angle with the point it starts at. This works fine, except that for large distances it will burst through the surface of the planet out into space. This can be see in the left figure below. The other option is to look at a constant angle as an angle which remains constant with the surface above. This results in a logarithmic spiral as seen in the right figure below.
When defining a line with a certain angle to the surface in a sphere, you can look at this in one of two ways. The first option is to define a constant angle at its starting point. This works mostly fine except for large distances where it will burst through the surface of the planet out into space. This can be see in the left figure below. The other option is to define a constatnt angle with respect to the surface above. This results in a logarithmic spiral as seen in the right figure below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When defining a line with a certain angle to the surface in a sphere, you can look at this in one of two ways. The first option is to define a constant angle at its starting point. This works mostly fine except for large distances where it will burst through the surface of the planet out into space. This can be see in the left figure below. The other option is to define a constatnt angle with respect to the surface above. This results in a logarithmic spiral as seen in the right figure below.
When defining a line with a certain angle to the surface in a sphere, you can look at this in one of two ways. The first option is to define a constant angle at its starting point. This works mostly fine except for large distances where it will burst through the surface of the planet out into space. This can be seen in the left figure below. The other option is to define a constant angle with respect to the surface above. This results in a logarithmic spiral as seen in the right figure below.


::::{grid} 2

Expand All @@ -22,6 +22,6 @@ The issue arises when you want to define a line with a certain angle to the surf
:::
::::

Currently only the left figure, and something in between the left and right figure has been implemented in the GWB. The in between option is that for each line segment it can adjust the angle to be the correct angle with respect to the surface. Implementing the way it is done in the right figure, is possible if there is enough interest.
Currently only the first option (left figure), and something in between the first and second option (right figure) has been implemented in the GWB. For this in between option, the angle of each line segment can be adjusted to the correct angle with respect to the surface. Implementing this fully (right figure) is possible if there is enough interest.

In the GWB this is defined in the spherical coordinate system through something called a `depth method`. The left figure method is called `starting point`, because the angle is set and kept relative to the starting point. The in between option is called `begin segment`, because the angle is relative to the beginning of each segment. The right figure method is called `contiuous`, and is not implemented.
In the GWB this concept is defined in the spherical coordinate system through something called a `depth method`. The left figure method is called `starting point` because the angle is set and kept relative to the starting point. The in between option is called `begin segment` because the angle is relative to the beginning of each segment. The right figure method is called `contiuous` and is not implemented.
Loading