Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contidtionally output the json files #562

Conversation

MFraters
Copy link
Member

This is a follow up on #555. This moves the files and the generation location.

@MFraters MFraters force-pushed the contidtionally_output_the_json_files branch from b2dd798 to f3ed971 Compare February 13, 2024 23:42
Copy link

github-actions bot commented Feb 14, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.024 ± 0.007 (s=419) 1.025 ± 0.004 (s=462) -0.0% .. +0.2%
Slab interpolation curved simple none 1.026 ± 0.005 (s=449) 1.027 ± 0.002 (s=430) -0.0% .. +0.1%
Spherical slab interpolation simple none 1.265 ± 0.004 (s=348) 1.263 ± 0.003 (s=366) -0.2% .. -0.1%
Slab interpolation simple curved CMS 1.097 ± 0.006 (s=415) 1.099 ± 0.007 (s=407) +0.0% .. +0.3%
Spherical slab interpolation simple CMS 1.862 ± 0.006 (s=269) 1.860 ± 0.006 (s=217) -0.2% .. -0.0%
Spherical fault interpolation simple none 1.275 ± 0.006 (s=360) 1.273 ± 0.010 (s=349) -0.3% .. +0.0%
Cartesian min max surface 2.385 ± 0.019 (s=172) 2.381 ± 0.015 (s=208) -0.4% .. +0.1%
Spherical min max surface 7.350 ± 0.014 (s=68) 7.344 ± 0.013 (s=57) -0.2% .. +0.0%

@MFraters MFraters force-pushed the contidtionally_output_the_json_files branch from a4fcf4f to 9e3c789 Compare February 14, 2024 02:01
@MFraters MFraters force-pushed the contidtionally_output_the_json_files branch from 5bd5ebb to 3149289 Compare February 14, 2024 03:33
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ddab11) 93.55% compared to head (3149289) 93.55%.
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          92       92           
  Lines        6343     6346    +3     
=======================================
+ Hits         5934     5937    +3     
  Misses        409      409           
Files Coverage Δ
source/gwb-dat/main.cc 100.00% <100.00%> (ø)
source/gwb-grid/main.cc 46.29% <ø> (ø)
source/world_builder/types/double.cc 100.00% <100.00%> (ø)
source/world_builder/world.cc 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c8592...3149289. Read the comment docs.

@MFraters MFraters merged commit e8caa89 into GeodynamicWorldBuilder:main Feb 14, 2024
33 of 34 checks passed
@MFraters MFraters mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant