Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of github actions workflows #561

Merged

Conversation

gassmoeller
Copy link
Contributor

This change improves the efficiency of the world builder testers by taking over the following changes from workflows of other CIG software:

  1. Only execute tests when pushing to the main branch (=merging) or pushing to an open pull request. Do not execute when pushing to private branches on github forks.
  2. Cancel in progress tester runs if a new commit is pushed to a pull request. Since a new run has to be done anyway, there is no point in finishing running tests.

Since WB testers are fast there is not much gained in terms of development speed, but this will save some energy somewhere in the cloud.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05df5d4) 93.55% compared to head (bc0e464) 93.55%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          92       92           
  Lines        6342     6342           
=======================================
  Hits         5933     5933           
  Misses        409      409           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05df5d4...bc0e464. Read the comment docs.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is useful.

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 13, 2024
@gassmoeller gassmoeller merged commit 23c8592 into GeodynamicWorldBuilder:main Feb 13, 2024
25 of 26 checks passed
@gassmoeller gassmoeller deleted the improve_tester_efficiency branch February 13, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants