Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a cookbook #547

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix a cookbook #547

merged 2 commits into from
Feb 13, 2024

Conversation

tjhei
Copy link
Contributor

@tjhei tjhei commented Feb 13, 2024

gwb-grid fails without this change

@MFraters should the tester catch this? where is the logic that runs the ./cookbooks/?

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b72ce04) 93.49% compared to head (0e9c751) 93.49%.
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          92       92           
  Lines        6346     6346           
=======================================
  Hits         5933     5933           
  Misses        413      413           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72ce04...0e9c751. Read the comment docs.

Copy link

github-actions bot commented Feb 13, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.021 ± 0.003 (s=427) 1.022 ± 0.003 (s=456) +0.0% .. +0.1%
Slab interpolation curved simple none 1.026 ± 0.004 (s=445) 1.026 ± 0.003 (s=435) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.260 ± 0.008 (s=344) 1.261 ± 0.014 (s=372) -0.1% .. +0.3%
Slab interpolation simple curved CMS 1.099 ± 0.003 (s=407) 1.099 ± 0.004 (s=415) -0.1% .. +0.1%
Spherical slab interpolation simple CMS 1.859 ± 0.005 (s=252) 1.858 ± 0.005 (s=235) -0.1% .. +0.1%
Spherical fault interpolation simple none 1.264 ± 0.009 (s=339) 1.264 ± 0.008 (s=376) -0.2% .. +0.2%
Cartesian min max surface 2.366 ± 0.018 (s=199) 2.369 ± 0.021 (s=184) -0.1% .. +0.4%
Spherical min max surface 7.368 ± 0.025 (s=64) 7.370 ± 0.021 (s=61) -0.2% .. +0.2%

@tjhei
Copy link
Contributor Author

tjhei commented Feb 13, 2024

I found two places where this is used.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for finding this. This is ready to merge.

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 13, 2024
@MFraters MFraters merged commit 1cb6661 into GeodynamicWorldBuilder:main Feb 13, 2024
34 checks passed
@tjhei tjhei deleted the fix_a_cookbook branch February 13, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants