Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of python package #544

Merged

Conversation

gassmoeller
Copy link
Contributor

It looks like sphinx_book_theme is actually sphinx-book-theme, see https://pypi.org/project/sphinx-book-theme/. Maybe it changed its name. Let's wait for the documentation tester before merging this to make sure the new version still works.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d465a69) 93.49% compared to head (8c60ac3) 93.49%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          92       92           
  Lines        6346     6346           
=======================================
  Hits         5933     5933           
  Misses        413      413           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d465a69...8c60ac3. Read the comment docs.

@gassmoeller
Copy link
Contributor Author

Ok, looks like the documentation tester succeeded with the new name. I compared the build logs of readthedocs before/after and they look the same. Probably sphinx_book_theme was the old name, but is still supported, but sphinx-book-theme is the new name (since it is the only one listed on pypi).

This should be good to go once the other testers have finished.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.020 ± 0.003 (s=435) 1.020 ± 0.005 (s=450) -0.1% .. +0.1%
Slab interpolation curved simple none 1.028 ± 0.005 (s=443) 1.027 ± 0.004 (s=435) -0.2% .. -0.0%
Spherical slab interpolation simple none 1.261 ± 0.008 (s=361) 1.260 ± 0.006 (s=355) -0.2% .. +0.1%
Slab interpolation simple curved CMS 1.099 ± 0.004 (s=398) 1.100 ± 0.004 (s=423) +0.0% .. +0.2%
Spherical slab interpolation simple CMS 1.856 ± 0.004 (s=239) 1.862 ± 0.006 (s=248) +0.2% .. +0.4%
Spherical fault interpolation simple none 1.270 ± 0.007 (s=339) 1.270 ± 0.004 (s=372) -0.1% .. +0.1%
Cartesian min max surface 2.362 ± 0.018 (s=199) 2.366 ± 0.018 (s=184) -0.1% .. +0.4%
Spherical min max surface 7.370 ± 0.022 (s=53) 7.368 ± 0.021 (s=72) -0.2% .. +0.2%

@MFraters MFraters merged commit 1ae31ff into GeodynamicWorldBuilder:main Feb 13, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants