Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer documentation for astyle #541

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

danieldouglas92
Copy link
Contributor

Add details for downloading, installing, and using astyle for worldbuilder.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40655ff) 93.46% compared to head (98f5bee) 93.49%.
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   93.46%   93.49%   +0.03%     
==========================================
  Files          92       92              
  Lines        6301     6346      +45     
==========================================
+ Hits         5889     5933      +44     
- Misses        412      413       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40655ff...98f5bee. Read the comment docs.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for writing this up! The aspect wiki also has a oneline version of the to compile and install, could you also add there here and squash your commits?

https://github.com/geodynamics/aspect/wiki/Indenting-code-and-installing-the-correct-version-of-astyle

Otherwise looks good to go.

Copy link

github-actions bot commented Feb 13, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.024 ± 0.007 (s=449) 1.024 ± 0.007 (s=433) -0.1% .. +0.2%
Slab interpolation curved simple none 1.024 ± 0.004 (s=414) 1.025 ± 0.006 (s=467) -0.0% .. +0.2%
Spherical slab interpolation simple none 1.262 ± 0.005 (s=355) 1.262 ± 0.004 (s=361) -0.1% .. +0.1%
Slab interpolation simple curved CMS 1.097 ± 0.004 (s=417) 1.097 ± 0.004 (s=406) -0.1% .. +0.1%
Spherical slab interpolation simple CMS 1.865 ± 0.007 (s=239) 1.864 ± 0.009 (s=246) -0.2% .. +0.0%
Spherical fault interpolation simple none 1.271 ± 0.003 (s=378) 1.272 ± 0.004 (s=332) -0.0% .. +0.1%
Cartesian min max surface 2.367 ± 0.019 (s=209) 2.369 ± 0.023 (s=174) -0.2% .. +0.4%
Spherical min max surface 7.324 ± 0.015 (s=61) 7.325 ± 0.028 (s=64) -0.2% .. +0.2%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small comment on the new text, otherwise good to go.

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 13, 2024
@MFraters MFraters merged commit 53bed29 into GeodynamicWorldBuilder:main Feb 13, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants