Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for PR #520 #524

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

danieldouglas92
Copy link
Contributor

Forgot to modify the changelog file for PR #520

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84511b5) 93.46% compared to head (a437401) 93.46%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files          92       92           
  Lines        6301     6301           
=======================================
  Hits         5889     5889           
  Misses        412      412           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84511b5...a437401. Read the comment docs.

Copy link

github-actions bot commented Jan 22, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.029 ± 0.009 (s=421) 1.031 ± 0.009 (s=455) -0.0% .. +0.4%
Slab interpolation curved simple none 1.026 ± 0.006 (s=467) 1.029 ± 0.007 (s=412) +0.1% .. +0.4%
Spherical slab interpolation simple none 1.260 ± 0.005 (s=347) 1.259 ± 0.004 (s=370) -0.1% .. +0.0%
Slab interpolation simple curved CMS 1.097 ± 0.004 (s=390) 1.097 ± 0.005 (s=433) -0.1% .. +0.1%
Spherical slab interpolation simple CMS 1.857 ± 0.008 (s=238) 1.857 ± 0.006 (s=249) -0.1% .. +0.1%
Spherical fault interpolation simple none 1.274 ± 0.006 (s=345) 1.272 ± 0.005 (s=365) -0.3% .. -0.1%
Cartesian min max surface 2.379 ± 0.025 (s=196) 2.379 ± 0.024 (s=185) -0.4% .. +0.3%
Spherical min max surface 7.342 ± 0.014 (s=63) 7.343 ± 0.019 (s=62) -0.1% .. +0.1%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a link to the issue #518? Otherwise looks good!

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Jan 23, 2024
@MFraters MFraters merged commit c3188ad into GeodynamicWorldBuilder:main Jan 23, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants