-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only limit the Bezier curve closest point at the end of the whole curve #523
Only limit the Bezier curve closest point at the end of the whole curve #523
Conversation
|
58535a8
to
4ba3ad3
Compare
4ba3ad3
to
f5e02d1
Compare
f5e02d1
to
b48c0eb
Compare
b48c0eb
to
aabc002
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 92 92
Lines 6301 6301
=======================================
Hits 5889 5889
Misses 412 412
Continue to review full report in Codecov by Sentry.
|
aabc002
to
70cf179
Compare
After looking into a few changed test results, the provided test case and some of my more complex models, I think this pull request is ready to merge. @danieldouglas92, could you have a look at this pull request to see if 1. it resolves the issue in #522, and 2. your models still work. |
…ve, while keeping the interior able to go beyond the normal to the line.
70cf179
to
0580460
Compare
Looking at issue #522, I realized that the end points of slabs and fault (i.e. bezier curves) are not handled properly. The issues stems form wanting to find the closest point to a line consisting of segments. It can happen that the closest point found is just off the segment. In the interior this may be fine (especially if the derivatives are non-continuous, although I should revisit this in the future again because with Bezier Curves they now should be), but it should not happen at the edges of the full line itself.
This part at the end of line lines can be easily tested for, which is what this pull request does. I tested it with the provided example and this fixes the issue in #522.
This may break tests and I need to do some more testing to look if it breaks anything else it should not break.