Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra_navbar from sphinx conf.py #481

Merged

Conversation

MFraters
Copy link
Member

extra_navbar was removed in executablebooks/sphinx-book-theme#640, and now throws a warning. Since warning are turned in to errors by the settings, we probably need to remove this setting. I will see how the results look like online and see if it need tweaks.

@MFraters MFraters added documentation enhancement Requests for improvements to the documentation ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. labels Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #481 (715b880) into main (32f081b) will not change coverage.
The diff coverage is n/a.

❗ Current head 715b880 differs from pull request most recent head 35e9107. Consider uploading reports for the commit 35e9107 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files          91       91           
  Lines        6406     6406           
=======================================
  Hits         5820     5820           
  Misses        586      586           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f081b...35e9107. Read the comment docs.

@MFraters
Copy link
Member Author

The fix works and the updated theme (which caused the issue) looks good to me.

@github-actions
Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.458 ± 0.020 (s=300) 1.458 ± 0.023 (s=320) -0.4% .. +0.4%
Slab interpolation curved simple none 1.197 ± 0.003 (s=366) 1.197 ± 0.003 (s=389) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.579 ± 0.084 (s=300) 1.572 ± 0.007 (s=274) -1.5% .. +0.6%
Slab interpolation simple curved CMS 1.661 ± 0.027 (s=258) 1.665 ± 0.030 (s=286) -0.2% .. +0.8%
Spherical slab interpolation simple CMS 2.365 ± 0.010 (s=193) 2.364 ± 0.007 (s=190) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.520 ± 0.007 (s=286) 1.519 ± 0.007 (s=309) -0.2% .. +0.1%
Cartesian min max surface 4.077 ± 0.027 (s=103) 4.075 ± 0.034 (s=120) -0.4% .. +0.3%
Spherical min max surface 10.518 ± 0.159 (s=47) 10.477 ± 0.109 (s=41) -1.3% .. +0.5%

@MFraters MFraters merged commit 9ea9d74 into GeodynamicWorldBuilder:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement Requests for improvements to the documentation ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant