Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant copybutton requirement #395

Merged

Conversation

cmills1095
Copy link
Contributor

Removed the redundant copybutton requirement in requirements.txt

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

github-actions bot commented Mar 11, 2022

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.092 ± 0.030 (s=436) 1.090 ± 0.025 (s=391) -0.8% .. +0.3%
Slab interpolation curved simple none 1.480 ± 0.017 (s=304) 1.480 ± 0.018 (s=307) -0.3% .. +0.3%
Spherical slab interpolation simple none 1.596 ± 0.057 (s=291) 1.597 ± 0.062 (s=275) -1.0% .. +1.1%
Slab interpolation simple curved CMS 2.231 ± 0.022 (s=209) 2.233 ± 0.026 (s=197) -0.3% .. +0.4%
Spherical slab interpolation simple CMS 2.322 ± 0.069 (s=195) 2.332 ± 0.074 (s=194) -0.6% .. +1.5%
Spherical fault interpolation simple none 1.792 ± 0.018 (s=247) 1.792 ± 0.018 (s=258) -0.3% .. +0.3%

@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #395 (b4a08b9) into main (56e20c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          79       79           
  Lines        4711     4711           
=======================================
  Hits         4664     4664           
  Misses         47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e20c6...b4a08b9. Read the comment docs.

@MFraters
Copy link
Member

There was an issue with the github tester which I couldn't reset through the controls. Pushing another commit did fix the issue. The commit I pushed is unrelated to the pull request, but adds an extra page to the manual on the coupling of the GWB and ASPECT. I hope this was just a one-time glitch in the tester.

@MFraters MFraters merged commit 8649fc7 into GeodynamicWorldBuilder:main Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants