Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add temperature plate model constant age to oceanic plate models #344

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

lhy11009
Copy link
Contributor

I add a "plate model constant age" plugin under "oceanic plate". This takes a constant age of the plate and assign a temperature field using the plate model.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #344 (baf6681) into main (c8cddc4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   98.84%   98.85%   +0.01%     
==========================================
  Files          76       77       +1     
  Lines        4428     4472      +44     
==========================================
+ Hits         4377     4421      +44     
  Misses         51       51              
Impacted Files Coverage Δ
...ate_models/temperature/plate_model_constant_age.cc 100.00% <100.00%> (ø)
...es/oceanic_plate_models/temperature/plate_model.cc 98.55% <0.00%> (ø)
...ucting_plate_models/temperature/mass_conserving.cc 97.20% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cddc4...baf6681. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 22, 2021

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.276 ± 0.080 (s=341) 1.288 ± 0.124 (s=364) -1.1% .. +3.0%
Slab interpolation curved simple none 1.202 ± 0.038 (s=352) 1.199 ± 0.042 (s=400) -1.1% .. +0.5%
Spherical slab interpolation simple none 1.406 ± 0.004 (s=320) 1.405 ± 0.004 (s=323) -0.2% .. -0.0%
Slab interpolation simple curved CMS 1.998 ± 0.065 (s=238) 1.999 ± 0.065 (s=215) -1.0% .. +1.0%
Spherical slab interpolation simple CMS 2.585 ± 0.011 (s=170) 2.575 ± 0.007 (s=181) -0.5% .. -0.3%
Spherical fault interpolation simple none 1.836 ± 0.025 (s=228) 1.836 ± 0.026 (s=265) -0.4% .. +0.4%

@MFraters
Copy link
Member

Thanks for making this into a pull request. It looks good to me. I had to think a bit about issue #351, but since it is an issue with all the oceanic temperature models, I don't think it should hold back this pull request.

Can you add a test and a line in the changelog? Let me know if you need help with either.

@lhy11009
Copy link
Contributor Author

Yes, I would like to ask these questions.
a. I see there are a bunch of tests under test/app, I assume that's where the new test needs to be?
b. I see there is a ".dat" file for each test. For example, there is a "half_space_plate_model.dat" for the test "half_space_plate_model". What's that for?
c. It seems I could do "make test" in the build folder, but that would run all the tests. Is there a way to run just one test? Let me know if you'd like to answer in an email to prefer me to come to your office.

@MFraters
Copy link
Member

a. There are different kind of test, but I think that that is indeed the best kind for this plugin.
b. The app test uses the world builder app to produce output which queries the world builder at different locations. The .dat file contains the positions in the model which you want to check.
c. ctest -R name_of_test or ctest -VV -R name_of_test if you want more output.

I hope this answers your questions, otherwise let me know :)

@lhy11009
Copy link
Contributor Author

Hi @MFraters
Thanks for the advice. I have added one test as well as edited the CHANGE_LOG.md. Please take a look at it when you have time.

@lhy11009
Copy link
Contributor Author

Hi
@MFraters, I am not sure what's the problem here. It complains that there is no test point that is out of the range defined for the feature, is that correct? While the "max depth" defined in the test wb file is 250e3 but there is query points at 300e3 (dat) file, then why is this the case? Can you help to explain it a bit, thankss?

@MFraters
Copy link
Member

Great, thanks for the pull request and making the changes!

@MFraters MFraters merged commit 5d7d7ae into GeodynamicWorldBuilder:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants