Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 3.0 breaks this plug-in, here's the fix #16

Open
skills0 opened this issue Aug 23, 2016 · 0 comments
Open

jQuery 3.0 breaks this plug-in, here's the fix #16

skills0 opened this issue Aug 23, 2016 · 0 comments

Comments

@skills0
Copy link

skills0 commented Aug 23, 2016

I haven't fully vetted this, but jQuery 3.x finally removed the ".context" property that was deprecated in version 1.1. This is being used to set up the element property on defaults and htmlOptions in this plug-in.

I basically just removed ".context" and left the setters to just $(this) and everything seems to work.

i.e

var defaults = {
element: $(this),

and

var htmlOptions = {
element: $(this),

Appreciate any feedback or if anyone finds an issue created by this change. The plug-in just doesn't work at all in 3.x otherwise.

MouettE-SC added a commit to MouettE-SC/DualListBox that referenced this issue Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant