List endpoint #11
Merged
List endpoint #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlive
commented
Sep 13, 2024
MiniCodeMonkey
approved these changes
Sep 20, 2024
| # Find files fixed by pint by comparing file lists before and after pint run | ||
| files_fixed_by_format=$(comm -13 <(sort <<<"$files_before_format") <(sort <<<"$files_after_format")) | ||
|
|
||
| # Re-stage files fixed by pint |
composer.json
Outdated
| @@ -25,7 +25,8 @@ | |||
| "phpunit/phpunit": "^11.0", | |||
| "projektgopher/whisky": "^0.7.0", | |||
| "rector/rector": "^1.2", | |||
| "symfony/var-dumper": "^4.3" | |||
| "symfony/var-dumper": "^4.3", | |||
| "spatie/ray": "^1.41" | |||
|
|
||
| protected function formatUrl(string $endpoint): string | ||
| { | ||
| return vsprintf('https://%s/%s/%s', [ |
There was a problem hiding this comment.
TIL: There's a vsprintf(...) :)
There was a problem hiding this comment.
I love sprintf and vsprintf I use them all the time for string formatting.
| protected function getHeaders(): array | ||
| { | ||
| return [ | ||
| 'User-Agent' => sprintf('geocodio-library-php/%s', Geocodio::SDK_VERSION), |
| ?string $filename = null | ||
| ): Response { | ||
| if (is_file($fileContents) && ! file_exists($fileContents)) { | ||
| throw GeocodioException::fileNotFound($fileContents); |
sixlive
force-pushed
the
list-endpoint
branch
from
994cd9b
to
c212b57
Compare
MiniCodeMonkey
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
❗This PR is built off of #10
json_decodeobjectdescribemethod