Skip to content

Commit

Permalink
Merge pull request #330 from GeoWerkstatt/nodejs-20
Browse files Browse the repository at this point in the history
Update to Node.js 20
  • Loading branch information
domi-b authored Jan 31, 2024
2 parents c9d186e + 853a70e commit ede4971
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ jobs:
with:
dotnet-version: 6.0.x

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20

# Run the npm ci command before building
# the dotnet project, because the project
# itself calls npm install if the node_modules
Expand Down
13 changes: 10 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,16 @@ ARG REVISION
# Set default shell
SHELL ["/bin/bash", "-c"]

# Install missing packages
RUN curl -sL https://deb.nodesource.com/setup_18.x | bash -
RUN apt-get install -y nodejs unzip
# Install Node.js
RUN apt-get update && \
apt-get install -y gnupg && \
mkdir -p /etc/apt/keyrings && \
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
NODE_MAJOR=20 && \
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
apt-get update && \
apt-get install -y nodejs && \
rm -rf /var/lib/apt/lists/*

# Install latest DocFX release
RUN dotnet tool update -g docfx
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Folgende Komponenten müssen auf dem Entwicklungsrechner installiert sein:
* Git
* Docker
* Visual Studio 2022 oder Visual Studio Code
* Node.js 18 LTS
* Node.js 20 LTS
* Optional, um die Onlinehilfe zu erstellen:
* [DocFX](https://github.com/dotnet/docfx)

Expand Down

0 comments on commit ede4971

Please sign in to comment.