Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #6414] Delete thumbnails using Django file storage API #6415

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

mtnorthcott
Copy link
Contributor

@mtnorthcott mtnorthcott commented Sep 8, 2020

PR to perform thumbnail deletions using the Django file storage API.

Previously, os.remove was used to delete files from Django storage, which did not function correctly for remote storage as this is not implemented. This fix uses Django's storage.delete method instead which will work if the chosen storage plug-in implements it.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 8, 2020
@mtnorthcott mtnorthcott force-pushed the fix_thumbnail_delete branch 3 times, most recently from d6175bb to cd9065e Compare September 8, 2020 03:38
@mtnorthcott mtnorthcott changed the title [Fixes #6414] Fixed thumbnail deletion when using remote storage [Issue #6414] Delete thumbnails using Django file storage API Sep 8, 2020
@afabiani afabiani force-pushed the master branch 4 times, most recently from ed0ea78 to 2c4a08a Compare September 8, 2020 09:49
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #6415 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6415      +/-   ##
==========================================
+ Coverage   59.00%   59.02%   +0.01%     
==========================================
  Files         184      184              
  Lines       20569    20569              
  Branches     3415     3416       +1     
==========================================
+ Hits        12136    12140       +4     
+ Misses       7360     7356       -4     
  Partials     1073     1073              

@afabiani afabiani added this to the 3.1 milestone Sep 8, 2020
@afabiani afabiani merged commit d4c9311 into GeoNode:master Sep 8, 2020
afabiani pushed a commit that referenced this pull request Sep 10, 2020
Co-authored-by: Alessio Fabiani <[email protected]>
(cherry picked from commit d4c9311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants