Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5105] Error when using THESAURI #5157

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

t-book
Copy link
Contributor

@t-book t-book commented Oct 30, 2019

This will stop the error:

File "/Users/ts/github/csgis.geonode/geonode/base/widgets.py", line 33, in __init__
    autocomplete_light.MultipleChoiceWidget(
AttributeError: 'module' object has no attribute 'MultipleChoiceWidget'

From what I see classautocomplete_light.MultipleChoiceWidget is now

classautocomplete_light.widgets.MultipleChoiceWidget(autocomplete=None, widget_js_attributes=None, autocomplete_js_attributes=None, extra_context=None, registry=None, widget_template=None, widget_attrs=None, *args, **kwargs)

@afabiani @capooti this should fix the described issue however I would suggest that we continue here: #5158

Checklist

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 30, 2019
@t-book t-book changed the title [Fixes #5105] Error when using THESAURI [DRAFT] [Fixes #5105] Error when using THESAURI Oct 30, 2019
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #5157 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5157   +/-   ##
=======================================
  Coverage   53.67%   53.67%           
=======================================
  Files         185      185           
  Lines       20821    20821           
  Branches     3314     3314           
=======================================
  Hits        11175    11175           
  Misses       8635     8635           
  Partials     1011     1011

@t-book t-book changed the title [DRAFT] [Fixes #5105] Error when using THESAURI [Fixes #5105] Error when using THESAURI Oct 30, 2019
@t-book t-book marked this pull request as ready for review October 30, 2019 10:41
@afabiani afabiani merged commit c68389c into GeoNode:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants