Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5089] Update index.html #5090

Merged
merged 1 commit into from
Oct 23, 2019
Merged

[Fixes #5089] Update index.html #5090

merged 1 commit into from
Oct 23, 2019

Conversation

gannebamm
Copy link
Contributor

@gannebamm gannebamm commented Oct 22, 2019

fixes #5089

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 22, 2019
@gannebamm
Copy link
Contributor Author

regarding the CLA - did I sign it allready? The Bot says yes

@afabiani
Copy link
Member

@gannebamm probably you followed the old automatic procedure. If not, please send the signed CLA to OSGeo as specified in the contribution file. Thanks.

Just check the checkbox when you have done.

@afabiani afabiani changed the title Update index.html [Fixes #5089] Update index.html Oct 22, 2019
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #5090 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5090      +/-   ##
==========================================
- Coverage   53.58%   53.57%   -0.01%     
==========================================
  Files         185      185              
  Lines       20773    20773              
  Branches     3293     3293              
==========================================
- Hits        11132    11130       -2     
- Misses       8641     8642       +1     
- Partials     1000     1001       +1

@afabiani
Copy link
Member

@gannebamm let us know when we can merge this, thanks.

@gannebamm
Copy link
Contributor Author

@afabiani I sure will!
I used this to get it signed by the head of administration of the institute - which takes some time but is one more step closer to me becoming an official psc member in the near future 😉

@gannebamm
Copy link
Contributor Author

@gannebamm let us know when we can merge this, thanks.

@afabiani
The CLA is signed and sent.
You could merge this now. Codecov is a false error I guess for this simple fix in the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geoscience category button does search for farming category, too
3 participants