Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12368] Introduce geonode-importer in geonode-core #12570

Merged
merged 78 commits into from
Oct 16, 2024

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Sep 12, 2024

This PR will introduce the geonode-importer as a core module in geonode.
The PR includes also a cleanup of the no longer used models

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy
Copy link
Contributor

@mattiagiupponi some tests are failing. They don't seem related to this PR but let's give a look and fix them.

@giohappy giohappy closed this Oct 14, 2024
@giohappy giohappy reopened this Oct 14, 2024
Copy link
Contributor

@ridoo ridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extensive PR with a lot of changes. It's good to see a lot of deprecated code disappearing and being replaced by the new importer approach. I never had a chance to really look at the old code, but some parts seemed a bit brittle to me, anyway. So good work.

So I just took a quick look and made a few mini comments. Anyway, feel free to continue as you wish.

.env_test Outdated Show resolved Hide resolved
geonode/harvesting/harvesters/base.py Show resolved Hide resolved
geonode/resource/manager.py Outdated Show resolved Hide resolved
geonode/settings.py Show resolved Hide resolved
@mattiagiupponi
Copy link
Contributor Author

This is an extensive PR with a lot of changes. It's good to see a lot of deprecated code disappearing and being replaced by the new importer approach.

We know that the PR is huge, but it was the right moment to get rid of dead code and deprecated one.

I never had a chance to really look at the old code, but some parts seemed a bit brittle to me, anyway. So good work.

Lucky you! 😆

So I just took a quick look and made a few mini comments. Anyway, feel free to continue as you wish.

Comments are always welcome, feel free to add them

@mattiagiupponi mattiagiupponi merged commit b6a26f3 into master Oct 16, 2024
17 checks passed
@mattiagiupponi mattiagiupponi deleted the importer_in_core branch October 16, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include geonode-importer inside the core
3 participants