-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #12368] Introduce geonode-importer in geonode-core #12570
Conversation
* [Fixes #12124] GNIP 100: Assets --------- Co-authored-by: etj <[email protected]>
[Fixes #12226] Directory assets --------- Co-authored-by: etj <[email protected]>
@mattiagiupponi some tests are failing. They don't seem related to this PR but let's give a look and fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an extensive PR with a lot of changes. It's good to see a lot of deprecated code disappearing and being replaced by the new importer approach. I never had a chance to really look at the old code, but some parts seemed a bit brittle to me, anyway. So good work.
So I just took a quick look and made a few mini comments. Anyway, feel free to continue as you wish.
We know that the PR is huge, but it was the right moment to get rid of dead code and deprecated one.
Lucky you! 😆
Comments are always welcome, feel free to add them |
This PR will introduce the geonode-importer as a core module in geonode.
The PR includes also a cleanup of the no longer used models
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.