Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of style title from UserStyle.Title element #7390

Closed
giohappy opened this issue Apr 26, 2021 · 0 comments
Closed

Fix parsing of style title from UserStyle.Title element #7390

giohappy opened this issue Apr 26, 2021 · 0 comments
Assignees
Labels
regression Issues related to regressions.
Milestone

Comments

@giohappy
Copy link
Contributor

Several issues prevent the correct parsing of the style title from the UserStyle.Title element. This is used by MapStore for SLD styles, and is what is returned by Geoserver when converting from CSS (with @styleTitle property) to SLD.

  • gs-restconfig dep version must be updated when this PR will be merged and a new version of gs-restconfig will be published
  • review the reason of having the geoserver.helpers.style_update method, which is only used inside the geoserver.views.geoserver_proxy method in case of PUT requests. Why is this required if we have the geoserver post save signals?
  • if style_update is requested the following must be fixed:
    1. Code will never enter this line, since not elm_user_style_title returns always True even when the element is populated. It must be replaced with elm_user_style_title is None
    2. In case of a CSS style the @styleTitle must be parsed instead
@giohappy giohappy added regression Issues related to regressions. backport 3.2.x PR should be backported to target version labels Apr 26, 2021
@giohappy giohappy added this to the 3.2.1 milestone Apr 26, 2021
@giohappy giohappy added the Epic label Apr 26, 2021
@giohappy giohappy modified the milestones: 3.2.1, 3.2 Apr 27, 2021
@giohappy giohappy removed the Epic label Apr 27, 2021
@afabiani afabiani removed the backport 3.2.x PR should be backported to target version label Apr 27, 2021
afabiani pushed a commit that referenced this issue Apr 28, 2021
marthamareal pushed a commit to geosolutions-it/geonode that referenced this issue May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issues related to regressions.
Projects
None yet
Development

No branches or pull requests

2 participants