Error when uploading avatar in 1.2beta1

[ingenieroariel]

This may be a compatibility problem with Django 1.4 and django-avatar. @ischneider told me something about it a while ago.

Environment:


Request Method: POST
Request URL: http://localhost:8000/avatar/add/

Django Version: 1.4
Python Version: 2.7.0
Installed Applications:
('django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.admin',
 'django.contrib.sitemaps',
 'django.contrib.staticfiles',
 'django.contrib.messages',
 'django_extensions',
 'registration',
 'profiles',
 'avatar',
 'dialogos',
 'agon_ratings',
 'taggit',
 'south',
 'geonode.core',
 'geonode.maps',
 'geonode.proxy')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware')


Traceback:
File "/Users/ingenieroariel/work/geonode/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "/Users/ingenieroariel/work/geonode/lib/python2.7/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
  20.                 return view_func(request, *args, **kwargs)
File "/Users/ingenieroariel/work/geonode/src/avatar/avatar/views.py" in add
  71.             request.user.message_set.create(
File "/Users/ingenieroariel/work/geonode/lib/python2.7/site-packages/django/utils/functional.py" in inner
  185.         return func(self._wrapped, *args)

Exception Type: AttributeError at /avatar/add/
Exception Value: 'User' object has no attribute 'message_set'

[ischneider]

The messages framework changed in 1.4 - there is no longer a related manager attached to a User model. Instead of:

request.user.message_set.create(...)

One must use:

from django.contrib import messages messages.add_message(...)

A monkey patch for this exists here: https://github.com/opengeo/mapstory/blob/master/monkey_patch_avatar.py

I import this via settings, but this can cause import issues depending upon how code is loaded. A better approach would apply the patch using a request signal (and then detach) to ensure it works properly. Of course forking and patching avatar works best :)

[ingenieroariel]

Fixed in b00f949