Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite user feature has unclear field Maxuses #1856

Closed
vdeparday opened this issue Nov 27, 2014 · 8 comments
Closed

Invite user feature has unclear field Maxuses #1856

vdeparday opened this issue Nov 27, 2014 · 8 comments
Milestone
2.4

Comments

@vdeparday
Copy link
Member

I am not user what Maxuses mean, it should be made clearer.
Same for Notes. Does that mean email content?

image
@simod simod added this to the 2.4 milestone Dec 2, 2014
@capooti
Copy link
Member

capooti commented Dec 3, 2014

this is still something coming from Pinax. The idea there was to provide a
link that could be used to invite a number of users (specified in Max Uses).
If we don't need (as I believe) we can hide the form field and use 1 as
default.

On Thu, Nov 27, 2014 at 4:05 PM, Vivien Deparday [email protected]
wrote:

I am not user what Maxuses mean, it should be made clearer.
Same for Notes. Does that mean email content?

[image: image]
https://cloud.githubusercontent.com/assets/1036189/5218615/c21bba4e-761c-11e4-94fd-e85493dfee89.png

—
Reply to this email directly or view it on GitHub
#1856.

Paolo Corti
Geospatial software developer
web: http://www.paolocorti.net
twitter: @capooti
skype: capooti

@garnertb
Copy link
Member

I agree with @vdeparday, "max uses" is confusing and should be hidden by default. Also, from the screenshot it looks like this form needs the as_bootstrap template tag applied.

@state-hiu state-hiu mentioned this issue Jan 14, 2015
Open
@garnertb
Copy link
Member

garnertb commented Feb 3, 2015

I updated the invite user form: GeoNode/geonode-user-accounts@f29cbab.

Still need to push the new version to PyPI and bump the dependency in setup.py before closing this.

@capooti
Copy link
Member

capooti commented Feb 3, 2015

excellent.
Can you do it or would you like me to do? cheers

@garnertb
Copy link
Member

garnertb commented Feb 3, 2015

I can if I can get perms on the geonode-user-accounts package on PyPI.

@capooti
Copy link
Member

capooti commented Feb 3, 2015

sure, I will assign you as a maintainer. Which is your pypi username?

On Tue, Feb 3, 2015 at 3:27 PM, Tyler Garner [email protected]
wrote:

I can if I can get perms on the geonode-user-accounts package on PyPI.

—
Reply to this email directly or view it on GitHub
#1856 (comment).

Paolo Corti
Geospatial software developer
web: http://www.paolocorti.net
twitter: @capooti
skype: capooti

@garnertb
Copy link
Member

garnertb commented Feb 3, 2015

Its garnertb, thanks!

@capooti
Copy link
Member

capooti commented Feb 3, 2015

done it

On Tue, Feb 3, 2015 at 3:45 PM, Tyler Garner [email protected]
wrote:

Its garnertb, thanks!

—
Reply to this email directly or view it on GitHub
#1856 (comment).

Paolo Corti
Geospatial software developer
web: http://www.paolocorti.net
twitter: @capooti
skype: capooti

ppasq added a commit to ppasq/geonode that referenced this issue Feb 3, 2015
@ppasq
Merge branch 'master' of https://github.com/GeoNode/geonode
e7e25c2 
# By Tyler Garner (2) and others
# Via Jeffrey Johnson (1) and Tyler Garner (1)
* 'master' of https://github.com/GeoNode/geonode:
  Bump `geonode-user-accounts` version to 1.0.10.  Fixes GeoNode#1856.
  Add an inner try/except block when trying to clean up and delete_from_postgis. Closes GeoNode#1058
  Minor profile page enhancements.  Fixes GeoNode#1975.
  Updated changelog for version 2.4b16

Conflicts:
	geonode/static/geonode/css/base.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
5 participants
@capooti @jj0hns0n @simod @vdeparday @garnertb