feat: add domains table #2225
Open
feat: add domains table #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a simple domains table as the first step to linking delta with tilde
elidana
approved these changes
Oct 21, 2024
wilsonjord
reviewed
Oct 24, 2024
Comment on lines
+37
to
+38
| row.Name, | ||
| row.Description, |
There was a problem hiding this comment.
nitpick: probably never a problem in practice, but in theory:
d1 := DomainList{ Domain{ Name: "with space "}}
var d2 DomainList
d2.decode(d1.encode())
// d1[0].Name != d2[0].Name
Comment on lines
+265
to
+271
| for _, v := range s.domains { | ||
| if name != v.Name { | ||
| continue | ||
| } | ||
| return v, true | ||
| } | ||
| return Domain{}, false |
There was a problem hiding this comment.
suggestion: have you considered slices package, might be more concise...(7 LOC later)...nevermind 😑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple domains table as the first step to linking delta with tilde