Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notes): add a environment notes table #1752

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(notes): add a environment notes table #1752

wants to merge 2 commits into from

Conversation

ozym
Copy link
Contributor

@ozym ozym commented Jun 20, 2023

This is the makings of a "notes" table as per #1751 but a little more generic.

@ozym ozym requested review from a team June 20, 2023 05:51
@ozym ozym self-assigned this Jun 20, 2023
@ozym ozym added the enhancement New feature development work label Jun 20, 2023
@ozym ozym force-pushed the add-notes-table branch from de34d25 to 74d7e21 Compare June 20, 2023 10:11
bpeng
bpeng approved these changes Jul 4, 2023
View reviewed changes
Copy link

@bpeng bpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bpeng bpeng force-pushed the add-notes-table branch from 74d7e21 to 73d64ec Compare July 4, 2023 22:44
@ozym ozym force-pushed the add-notes-table branch from 73d64ec to a8fc547 Compare August 10, 2023 23:33
@elidana elidana requested a review from a team as a code owner October 18, 2023 22:59
elidana
elidana approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@elidana elidana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for what I can understand, this one looks good, not sure if it is still valid/desired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elidana elidana elidana approved these changes

@ardrigh ardrigh ardrigh approved these changes

@bpeng bpeng bpeng approved these changes

Assignees

@ozym ozym

Labels
enhancement New feature development work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozym @bpeng @ardrigh @elidana