feat(front) add column sorting to search-results-table #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…termine if the field is sortable or not and return the field name to use for sorting.
…t and not primitive)
…nto frontend-exp # Conflicts: # geonetwork-frontend/projects/glib/src/lib/search/search-results-table/search-results-table.component.html # geonetwork-frontend/projects/glib/src/lib/search/search-results-table/search-results-table.component.ts
fxprunayre
approved these changes
Sep 30, 2024
fxprunayre
added a commit
that referenced
this pull request
Oct 18, 2024
* Added column selection. * feat(front) : Added column selection in search-results-table webcomponent. * feat(front) : Added column selection in search-results-table webcomponent. * feat(front) : removed unused sorticon. * feat(front) : add sorting - created a function in SearchService to determine if the field is sortable or not and return the field name to use for sorting. * feat(front) : fixed issue with normalization (string must be an Object and not primitive) * feat(front) : fixed issue with normalization * feat(front) :sorting - fixed issue with primeng table sorting icon. * typo(front) : removed accent in field name. * feat(front) : sorting -> improved comments. * feat(front) : removed unused imports + fixed typo. * feat(front) : Sorting by .sort field and prettier. --------- Co-authored-by: GeryNi-personal <[email protected]> Co-authored-by: Francois Prunayre <[email protected]>
fxprunayre
added a commit
that referenced
this pull request
Oct 18, 2024
* Added column selection. * feat(front) : Added column selection in search-results-table webcomponent. * feat(front) : Added column selection in search-results-table webcomponent. * feat(front) : removed unused sorticon. * feat(front) : add sorting - created a function in SearchService to determine if the field is sortable or not and return the field name to use for sorting. * feat(front) : fixed issue with normalization (string must be an Object and not primitive) * feat(front) : fixed issue with normalization * feat(front) :sorting - fixed issue with primeng table sorting icon. * typo(front) : removed accent in field name. * feat(front) : sorting -> improved comments. * feat(front) : removed unused imports + fixed typo. * feat(front) : Sorting by .sort field and prettier. --------- Co-authored-by: GeryNi-personal <[email protected]> Co-authored-by: Francois Prunayre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature added: sorting on search-result-table (relying on the searchquery)