Add workaround for TCL Android 12 Smart TVs. #5148
Conversation
|
Thank you for your PR. I'm considering enabling all workarounds by default (I'm not sure yet), that would also fix your issue: #5154. |
Fixes #5140 <#5140> PR #5148 <#5148> Signed-off-by: Romain Vimont <[email protected]>
|
in any case, I will merge your commit first, in case the commit enabling all workarounds needs to be reverted in the future. I edited your commit a bit to use the same if-branch as the other devices, and removing the Android version check (too specific I guess): https://github.com/Genymobile/scrcpy/commits/pr5148/ Is it ok for you? |
|
Hi @rom1v ! Definitely cleaner to move it into the same branch but on removing the Android 12 scoping, its difficult to say as I don't have access to any other TCL devices (tvs, phones etc) for testing, but up to you - happy to merge like this if you are. Defaulting to prefilling the fake context sounds sensible as it may be a smaller list of devices that in fact aren't compatible and perhaps a config flag could skip that step in a future design to avoid further code changes being needed. |
|
👍 merged f691ebb into |
Fixes Genymobile#5140 <Genymobile#5140> PR Genymobile#5148 <Genymobile#5148> Signed-off-by: Romain Vimont <[email protected]>
Fixes Genymobile#5140 <Genymobile#5140> PR Genymobile#5148 <Genymobile#5148> Signed-off-by: Romain Vimont <[email protected]>
Fixes #5140
A fix for a bug which caused scrcpy to crash generating a video stream on certain TCL Android TVs.
Manufacturer's custom code expects to have access information about the activity.
Fix follows similar pattern to workarounds for other manufacturers, providing them the fake context.
Scoped only to android 12.