--no-playback, --no-video-playback, --no-audio-playback #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with the other parameters.
The AudioFormat contains several properties. This specific value is named "encoding".
Some devices (Vivo phones) fail to create an AudioRecord from an AudioRecord.Builder (which throws a NullPointerException). In that case, create an AudioRecord instance directly by reflection. The AOSP version of AudioRecord constructor code can be found at: - Android 11 (R): <https://cs.android.com/android/platform/superproject/+/android-11.0.0_r1:frameworks/base/media/java/android/media/AudioRecord.java;l=335;drc=64ed2ec38a511bbbd048985fe413268335e072f8> - Android 12 (S): <https://cs.android.com/android/platform/superproject/+/android-12.0.0_r1:frameworks/base/media/java/android/media/AudioRecord.java;l=388;drc=2eebf929650e0d320a21f0d13677a27d7ab278e9> - Android 13 (T, functionally identical to Android 12): <https://cs.android.com/android/platform/superproject/+/android-13.0.0_r1:frameworks/base/media/java/android/media/AudioRecord.java;l=382;drc=ed242da52f975a1dd18671afb346b18853d729f2> - Android 14 (U): Not released, but expected to change PR #3862 <#3862> Fixes #3805 <#3805> Signed-off-by: Romain Vimont <[email protected]>
This option impacts video and audio _playback_. For example, if we use V4L2, the device is still "mirrored" (via V4L2), even if playback is disabled. Therefore, "playback" is more approriate than "mirror". The initial option --no-display option was renamed to --no-mirror by commit 6928acd, but this has never been released, so it is ok to rename it one more time. Refs #3978 <#3978 (comment)> PR #4033 <#4033>
Perform checks that impact the options first.
For consistency, use the same error message for --v4l2-sink and --v4l2-buffer.
If V4L2 support is disabled, there is no v4l2 buffer option.
Define local variables whose value depends on ifdefs, to avoid cluttering all conditions with ifdefs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, rename
--no-mirrorto--no-playback(the initial option--no-displayoption was renamed to--no-mirrorby commit 6928acd, but this has never been released, so it is ok to rename it one more time). See #3978 (comment)Secondly, add two options to control video and audio playback separately:
--no-video-playback--no-audio-playback--no-playbackis now an alias for both.For example:
cc @kevsestrella (#3978 (comment)) @slr (#3989)